gortiz commented on code in PR #10528:
URL: https://github.com/apache/pinot/pull/10528#discussion_r1202457539
##########
.github/workflows/pinot_tests.yml:
##########
@@ -252,25 +268,29 @@ jobs:
name: Build Presto Pinot Driver
steps:
- uses: actions/checkout@v3
- - name: Set up JDK 11
- uses: actions/setup-java@v3
- with:
- java-version: 11
- distribution: 'adopt'
- cache: 'maven'
- - name: Build presto pinot driver with JDK 11
- env:
- MAVEN_OPTS: >
- -Xmx2G -DfailIfNoTests=false
-Dmaven.wagon.httpconnectionManager.ttlSeconds=25
- -Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false
-Dmaven.wagon.http.pool=false
- -XX:+IgnoreUnrecognizedVMOptions
- --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED
- --add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED
- --add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED
- --add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED
- --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
- run: |
- mvn clean install -DskipTests -Ppresto-driver -am -B -pl
':presto-pinot-driver' -T 16 || exit 1
+# Removed temporally given that sun.misc.Unsafe cannot be used from Java 11
with --release 8
Review Comment:
We may consider to remove this commented section for good, given that we
only want to distribute presto driver compiled with Java 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
