gortiz commented on code in PR #10528: URL: https://github.com/apache/pinot/pull/10528#discussion_r1202458380
########## config/suppressions.xml: ########## @@ -45,4 +45,7 @@ <!-- Allow static imports in tests --> <suppress checks="AvoidStaticImport" files="[\\/]src[\\/]test[\\/].*" /> + + <suppress checks="IllegalImport" files="Unsafer.java"/> + <suppress checks="IllegalImport" files="UnsafePinotBuffer.java"/> Review Comment: This has to be added, otherwise checkstyle fails when these classes are used. Specifically, this informs checkstyle to allow using illegal imports (which include sun.misc.Unsafe) in the classes listed here. Illegal imports cannot be used in other classes, as usual -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
