walterddr commented on code in PR #10797:
URL: https://github.com/apache/pinot/pull/10797#discussion_r1202730195
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotJoinExchangeNodeInsertRule.java:
##########
@@ -63,7 +65,13 @@ public void onMatch(RelOptRuleCall call) {
RelNode rightExchange;
JoinInfo joinInfo = join.analyzeCondition();
- if (joinInfo.leftKeys.isEmpty()) {
+ boolean isColocatedJoin =
PinotHintStrategyTable.containsHintOption(join.getHints(),
Review Comment:
Add extensive test for the hint config + singleton exchange (also add for
dynamic broadcast join)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
