walterddr commented on code in PR #10797:
URL: https://github.com/apache/pinot/pull/10797#discussion_r1202729305
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java:
##########
@@ -41,7 +42,13 @@ class SingletonExchange extends BlockExchange {
protected void route(List<SendingMailbox> mailbox, TransferableBlock block)
throws Exception {
for (SendingMailbox sendingMailbox : mailbox) {
- sendBlock(sendingMailbox, block);
+ if (isLocal(sendingMailbox)) {
Review Comment:
TODO for this PR
- Throw when 0, or more than 1 exchange is configured ( test on block
exchange unit test)
- Do not allow this in worker assignment strategy in the first place
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotJoinExchangeNodeInsertRule.java:
##########
@@ -63,7 +65,13 @@ public void onMatch(RelOptRuleCall call) {
RelNode rightExchange;
JoinInfo joinInfo = join.analyzeCondition();
- if (joinInfo.leftKeys.isEmpty()) {
+ boolean isColocatedJoin =
PinotHintStrategyTable.containsHintOption(join.getHints(),
Review Comment:
done
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java:
##########
@@ -41,7 +42,13 @@ class SingletonExchange extends BlockExchange {
protected void route(List<SendingMailbox> mailbox, TransferableBlock block)
throws Exception {
for (SendingMailbox sendingMailbox : mailbox) {
- sendBlock(sendingMailbox, block);
+ if (isLocal(sendingMailbox)) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
