walterddr commented on code in PR #10792:
URL: https://github.com/apache/pinot/pull/10792#discussion_r1205738972
##########
pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/creator/H3IndexConfigTest.java:
##########
@@ -84,4 +84,16 @@ public void withSomeData()
Assert.assertEquals(resolution.getLowestResolution(), 5);
Assert.assertEquals(resolution.getResolutions(), Lists.newArrayList(5, 6,
13));
}
+
+ @Test
+ public void serde()
+ throws JsonProcessingException {
+ H3IndexConfig initialConf = new H3IndexConfig(new
H3IndexResolution(Lists.newArrayList(5, 6, 13)));
+
+ String confAsJson = JsonUtils.objectToString(initialConf);
+ Assert.assertEquals(confAsJson,
"{\"disabled\":false,\"resolution\":[5,6,13]}");
Review Comment:
can we support both
`\"resolution\":[5,6,13]` and `\"resolution\":8663` (which is the
bit-shifted version of the array)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
