gortiz commented on code in PR #10792:
URL: https://github.com/apache/pinot/pull/10792#discussion_r1206336003
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java:
##########
@@ -91,4 +94,11 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(_resolutions);
}
+
+ public static class ToIntListConverted extends
StdConverter<H3IndexResolution, List<Integer>> {
Review Comment:
With the custom deserializer, `@JsonCreator` is not needed (and in fact it
may be confusing). I decided to serialize as list, but we can change that to
deserialize as short if you think that is better. I guess neither short or list
are human readable and short is always going to be smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
