yupeng9 commented on code in PR #10826:
URL: https://github.com/apache/pinot/pull/10826#discussion_r1212533342
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1426,6 +1470,21 @@ public LLRealtimeSegmentDataManager(SegmentZKMetadata
segmentZKMetadata, TableCo
try {
_partitionGroupConsumerSemaphore.acquire();
_acquiredConsumerSemaphore.set(true);
+ if (_tableConfig.getUpsertConfig() != null &&
_tableConfig.getUpsertConfig().isEnableSnapshot()) {
+ // block ingestion for new consuming segments
+ _isReadyToConsumeData = () -> false;
Review Comment:
so this will always override the `isReadyToConsumeData ` to
`LLRealtimeSegmentDataManager `. Is there any case that we want to use input
param?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
