ankitsultana commented on code in PR #10826:
URL: https://github.com/apache/pinot/pull/10826#discussion_r1215787274


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1426,6 +1430,20 @@ public LLRealtimeSegmentDataManager(SegmentZKMetadata 
segmentZKMetadata, TableCo
     try {
       _partitionGroupConsumerSemaphore.acquire();

Review Comment:
   Yeah that's what I think as well.
   
   I wasn't sure why two OFFLINE -> CONSUMING transitions may happen for two 
segments of the same partition on the same server so hence wanted to reproduce 
the issue once. One possible scenario I could think of was: when a server is 
restarted, the other server might commit a segment (say segment 10) and before 
the restarted server could process the offline -> consuming transition for 
segment 10, it might start processing the same for segment 11.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to