jtao15 commented on code in PR #10946:
URL: https://github.com/apache/pinot/pull/10946#discussion_r1235629041
##########
pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java:
##########
@@ -230,6 +230,11 @@ public interface RecordPurgerFactory {
* Get the {@link RecordPurger} for the given table.
*/
RecordPurger getRecordPurger(String rawTableName);
+
+ default RecordPurger getRecordPurger(String rawTableName, PinotTaskConfig
taskConfig, TableConfig tableConfig,
Review Comment:
We don't need `rawTableName` because it can be retrieved easily from the
`tableConfig`?
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##########
@@ -77,4 +77,14 @@ protected SegmentZKMetadataCustomMapModifier
getSegmentZKMetadataCustomMapModifi
.singletonMap(MinionConstants.PurgeTask.TASK_TYPE +
MinionConstants.TASK_TIME_SUFFIX,
String.valueOf(System.currentTimeMillis())));
}
+
+ private static SegmentPurger.RecordPurger getRecordPurger(PinotTaskConfig
pinotTaskConfig, String rawTableName,
+ SegmentPurger.RecordPurgerFactory recordPurgerFactory, TableConfig
tableConfig, Schema schema) {
+ if (recordPurgerFactory == null) {
+ return null;
+ }
+ SegmentPurger.RecordPurger recordPurger =
+ recordPurgerFactory.getRecordPurger(rawTableName, pinotTaskConfig,
tableConfig, schema);
+ return recordPurger != null ? recordPurger :
recordPurgerFactory.getRecordPurger(rawTableName);
Review Comment:
Is it better to just call `getRecordPurger(rawTableName)` in
`getRecordPurger(rawTableName, pinotTaskConfig, tableConfig, schema)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
