PrachiKhobragade commented on code in PR #10946:
URL: https://github.com/apache/pinot/pull/10946#discussion_r1236441550
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##########
@@ -46,14 +46,14 @@ protected SegmentConversionResult convert(PinotTaskConfig
pinotTaskConfig, File
String rawTableName =
TableNameBuilder.extractRawTableName(tableNameWithType);
SegmentPurger.RecordPurgerFactory recordPurgerFactory =
MINION_CONTEXT.getRecordPurgerFactory();
+ TableConfig tableConfig = getTableConfig(tableNameWithType);
+ Schema schema = getSchema(tableNameWithType);
SegmentPurger.RecordPurger recordPurger =
- recordPurgerFactory != null ?
recordPurgerFactory.getRecordPurger(rawTableName) : null;
+ getRecordPurger(pinotTaskConfig, recordPurgerFactory, tableConfig,
schema);
Review Comment:
Removed the method and kept the ternary operator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
