egalpin opened a new pull request, #11035: URL: https://github.com/apache/pinot/pull/11035
Relates to #11027 (and https://github.com/apache/pinot/pull/10704). **The summary of changes in this PR is: don't have `null` in `ComparisonColumns` list of `Comparables`, ever.** I believe this PR represents a way to _avoid_ getting into a situation where #11027 would be needed to recover; it doesn't, however, provide a way to recover from a "bad state" that #11027 _does_ help recover from. Given a column for which `isNull(<docId>)` returns true, previously an explicit `null` would be stored in the list of Comparables. After this PR, the `defaultValue` for that column would be stored in the list of Comparables instead of `null`. This allows for "regular" use of `removeNullValueField` for all (post-combined) non-null comparison columns. cc @KKcorps @Jackie-Jiang thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
