egalpin commented on code in PR #11035:
URL: https://github.com/apache/pinot/pull/11035#discussion_r1253734490
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -550,12 +550,12 @@ private Comparable getComparisonValue(GenericRow row) {
"Documents must have exactly 1 non-null comparison column value");
comparableIndex = i;
-
- Object comparisonValue = row.getValue(columnName);
- Preconditions.checkState(comparisonValue instanceof Comparable,
- "Upsert comparison column: %s must be comparable", columnName);
- comparisonValues[i] = (Comparable) comparisonValue;
}
+
Review Comment:
this change means that we always set a non-null value for each index of
`comparisonValues`, whereas previous all indices != `comparableIndex` would be
null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
