tibrewalpratik17 commented on PR #11103:
URL: https://github.com/apache/pinot/pull/11103#issuecomment-1635022420
> we shouldn't catch Throwable because Error usually means very serious
problem and shouldn't be handled. Can you also print the Error:
throw new
RuntimeException(ExplainPlanPlanVisitor.explain(dispatchableSubPlan), t);
The present error message doesn't tell anything and is really hard to debug
so catching the throwable would add value in debugging these issues faster.
Here's a sample error message after the change suggested:
`
[
{
"message": "QueryExecutionError:\njava.lang.RuntimeException:
[0]@127.0.0.1:60192 MAIL_RECEIVE(RANDOM_DISTRIBUTED)\n├── [1]@127.0.0.1:60213
MAIL_SEND(RANDOM_DISTRIBUTED)->{[0]@127.0.0.1@{60192,60192}|[0]} (Subtree
Omitted)\n├── [1]@127.0.0.1:60200
MAIL_SEND(RANDOM_DISTRIBUTED)->{[0]@127.0.0.1@{60192,60192}|[0]} (Subtree
Omitted)\n└── [1]@127.0.0.1:60207
MAIL_SEND(RANDOM_DISTRIBUTED)->{[0]@127.0.0.1@{60192,60192}|[0]}\n └──
[1]@127.0.0.1:60207 SORT LIMIT 10\n...\nCaused by: java.lang.NoSuchMethodError:
'io.grpc.NameResolver$Args$Builder
io.grpc.NameResolver$Args$Builder.setOverrideAuthority(java.lang.String)'\n\tat
io.grpc.internal.ManagedChannelImpl.<init>(ManagedChannelImpl.java:659)\n\tat
io.grpc.internal.ManagedChannelImplBuilder.build(ManagedChannelImplBuilder.java:631)\n\tat
io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:297)\n\tat
org.apache.pinot.query.service.dispatch.DispatchClient.<init>(Dispa
tchClient.java:46)",
"errorCode": 200
}
]
`
Do you think we should keep ExplainPlan in the errorResponse? Does it add a
lot of information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
