xiangfu0 commented on code in PR #11103:
URL: https://github.com/apache/pinot/pull/11103#discussion_r1263132905
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -101,6 +101,8 @@ public ResultTable submitAndReduce(long requestId,
DispatchableSubPlan dispatcha
} catch (Exception e) {
cancel(requestId, dispatchableSubPlan);
throw new RuntimeException("Error executing query: " +
ExplainPlanPlanVisitor.explain(dispatchableSubPlan), e);
+ } catch (Throwable t) {
Review Comment:
should you just merge Throwable with Exception?
Do you need to call `cancel(requestId, dispatchableSubPlan);` here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
