KKcorps opened a new pull request, #11129:
URL: https://github.com/apache/pinot/pull/11129

   * _tableUpsertMetadataManager variable is never initialised because we keep 
on waiting for `init`
   
   * this leads to NullPointerException when trying to preload the segments
   
   ```
   2023/07/18 10:20:13.526 INFO [ImmutableSegmentLoader] 
[segment-preload-thread-7] Successfully loaded segment: 
upsertMeetupRsvp_1678410006394_1678499996394_10 with SegmentDirectory
   2023/07/18 10:20:13.526 INFO 
[upsertMeetupRsvpLarge_REALTIME-RealtimeTableDataManager] 
[segment-preload-thread-7] Adding immutable segment: 
upsertMeetupRsvp_1678410006394_1678499996394_10 to upsert-enabled table: 
upsertMeetupRsvpLarge_REALTIME
   2023/07/18 10:20:13.526 ERROR [BaseTableDataManager] 
[segment-preload-thread-7] Failed to load existing segment: 
upsertMeetupRsvp_1678410006394_1678499996394_10 of table: 
upsertMeetupRsvpLarge_REALTIME with crc: 2719970321 on tier: default
   java.lang.NullPointerException: null
           at 
org.apache.pinot.core.data.manager.realtime.RealtimeTableDataManager.handleUpsert(RealtimeTableDataManager.java:534)
 
~[pinot-all-0.13.0-SNAPSHOT-jar-with-dependencies.jar:0.13.0-SNAPSHOT-47ec950074e6f5e6ce06671e376d828880b587d2]
           at 
org.apache.pinot.core.data.manager.realtime.RealtimeTableDataManager.addSegment(RealtimeTableDataManager.java:499)
 
~[pinot-all-0.13.0-SNAPSHOT-jar-with-dependencies.jar:0.13.0-SNAPSHOT-47ec950074e6f5e6ce06671e376d828880b587d2]
           at 
org.apache.pinot.core.data.manager.BaseTableDataManager.tryLoadExistingSegment(BaseTableDataManager.java:816)
 
~[pinot-all-0.13.0-SNAPSHOT-jar-with-dependencies.jar:0.13.0-SNAPSHOT-47ec950074e6f5e6ce06671e376d828880b587d2]
           at 
org.apache.pinot.segment.local.upsert.BaseTableUpsertMetadataManager.preloadSegmentWithSnapshot(BaseTableUpsertMetadataManager.java:213)
 
~[pinot-all-0.13.0-SNAPSHOT-jar-with-dependencies.jar:0.13.0-SNAPSHOT-47ec950074e6f5e6ce06671e376d828880b587d2]
           at 
org.apache.pinot.segment.local.upsert.BaseTableUpsertMetadataManager.preloadSegment(BaseTableUpsertMetadataManager.java:201)
 
~[pinot-all-0.13.0-SNAPSHOT-jar-with-dependencies.jar:0.13.0-SNAPSHOT-47ec950074e6f5e6ce06671e376d828880b587d2]
           at 
org.apache.pinot.segment.local.upsert.BaseTableUpsertMetadataManager.lambda$preloadSegments$0(BaseTableUpsertMetadataManager.java:157)
 
~[pinot-all-0.13.0-SNAPSHOT-jar-with-dependencies.jar:0.13.0-SNAPSHOT-47ec950074e6f5e6ce06671e376d828880b587d2]
           at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
           at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
           at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) 
[?:?]
           at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) 
[?:?]
           at java.lang.Thread.run(Thread.java:829) [?:?]
   2023/07/18 10:20:13.528 INFO [BaseTableUpsertMetadataManager] 
[segment-preload-thread-7] Preloaded segment: 
upsertMeetupRsvp_1678410006394_1678499996394_10 from table: 
upsertMeetupRsvpLarge_REALTIME
   ```
   
   * solution is to seperate out the create and init steps.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to