klsince commented on code in PR #11129:
URL: https://github.com/apache/pinot/pull/11129#discussion_r1267178494
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -210,8 +210,9 @@ protected void doInit() {
// this status with a boolean, instead of relying on if
_tableUpsertMetadataManager is null or not.
_isUpsertEnabled = true;
_tableUpsertMetadataManager =
- TableUpsertMetadataManagerFactory.create(tableConfig, schema, this,
_serverMetrics, _helixManager,
- _segmentPreloadExecutor);
+ TableUpsertMetadataManagerFactory.create(tableConfig);
Review Comment:
good catch. I think you can also remove `_isUpsertEnabled` bool flag and the
comments about it on L209-L211 above. That bool flag was introduced to allow
the blocking create() method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
