walterddr commented on code in PR #11201:
URL: https://github.com/apache/pinot/pull/11201#discussion_r1277601055
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -129,6 +130,11 @@ private void assignWorkersToLeafFragment(PlanFragment
fragment, DispatchablePlan
Preconditions.checkState(tableTypeToSegmentListMap.put(tableType,
serverEntry.getValue()) == null,
"Entry for server {} and table type: {} already exist!",
serverEntry.getKey(), tableType);
}
+
+ // attach unavailable segments to metadata
+ if (!routingTable.getUnavailableSegments().isEmpty()) {
+ metadata.addTableToUnavailableSegmentsMap(logicalTableName,
routingTable.getUnavailableSegments());
+ }
Review Comment:
cant we simply attach to `DispatchablePlanContext` this way no need to
change anything in fragment
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/DispatchablePlanFragment.java:
##########
@@ -46,17 +47,22 @@ public class DispatchablePlanFragment {
// used for passing custom properties to build StageMetadata on the server.
private final Map<String, String> _customProperties;
+ // Used for passing unavailable segments to generate partial results.
+ private final Map<String, Set<String>> _tableToUnavailableSegments;
Review Comment:
```suggestion
private final Map<String, Collection<String>> _tableToUnavailableSegments;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
