walterddr commented on code in PR #11201:
URL: https://github.com/apache/pinot/pull/11201#discussion_r1277912370
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -129,6 +130,11 @@ private void assignWorkersToLeafFragment(PlanFragment
fragment, DispatchablePlan
Preconditions.checkState(tableTypeToSegmentListMap.put(tableType,
serverEntry.getValue()) == null,
"Entry for server {} and table type: {} already exist!",
serverEntry.getKey(), tableType);
}
+
+ // attach unavailable segments to metadata
+ if (!routingTable.getUnavailableSegments().isEmpty()) {
+ metadata.addTableToUnavailableSegmentsMap(logicalTableName,
routingTable.getUnavailableSegments());
+ }
Review Comment:
yeah adding a new field to dispatchable subplan is what i meant.
e.g.
1. `WorkerManager` here attach all unavailable segments to
`dispatchablePlanContext._unavailableSegmentMap`
2. `PinotDispatchPlanner#finalizeDispatchableSubPlan` copies the map to
`DispachableSubPlan._unavailableSegmentMap`
there's no need for planFragment to know this as they cannot do anything
anyway. right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
