jadami10 commented on code in PR #11347:
URL: https://github.com/apache/pinot/pull/11347#discussion_r1294540054
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -651,8 +663,12 @@ public void stop() {
Server.DEFAULT_SHUTDOWN_ENABLE_RESOURCE_CHECK)) {
shutdownResourceCheck(endTimeMs);
}
- _serverQueriesDisabledTracker.stop();
- _realtimeLuceneIndexRefreshState.stop();
+ if (_serverQueriesDisabledTracker != null) {
Review Comment:
these null checks are technically not being used anymore, but the still feel
valid to have in place since it seems folks can subclass this and do whatever
they want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
