jadami10 commented on code in PR #11347:
URL: https://github.com/apache/pinot/pull/11347#discussion_r1300123117
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -501,6 +502,17 @@ private void startupServiceStatusCheck(long endTimeMs) {
}
}
+ boolean exitServerOnIncompleteStartup =
_serverConf.getProperty(Server.CONFIG_OF_EXIT_SERVER_ON_INCOMPLETE_STARTUP,
+ Server.DEFAULT_EXIT_SERVER_ON_INCOMPLETE_STARTUP);
+ if (exitServerOnIncompleteStartup) {
+ String errorMessage = String.format("Service status %s has not turned
GOOD within %dms: %s. Exiting server.",
+ serviceStatus, System.currentTimeMillis() - startTimeMs,
ServiceStatus.getStatusDescription());
+ LOGGER.error(errorMessage);
+ // If we exit here, only the _adminApiApplication and _helixManager are
initialized, so we only stop them
+ _adminApiApplication.stop();
+ _helixManager.disconnect();
Review Comment:
good idea. let me know what you think now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
