KKcorps commented on PR #11486: URL: https://github.com/apache/pinot/pull/11486#issuecomment-1703283423
> We should not fix this on the routing side, but on the assignment side. The assignment side should ensure all the segments are assigned to the same server when updating the IS. This guarantee might be violated now when IS doesn't align with instance partitions (either because new server added, or rebalance didn't go through). The correct fix should be to check the existing segment's assignment, detect mismatch and emit metric to alert, then assign the segment based on the existing segments' assignment. Makes sense but I think @mayankshriv wanted some way to not return results in case we run into similar situation again. Should we keep this as well them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
