KKcorps commented on PR #11486: URL: https://github.com/apache/pinot/pull/11486#issuecomment-1703946700
> @kishoreg Currently we use IS only to determine the segment group (segments that should be routed together). The actual segment state is read from the EV, and we can handle OFFLINE/ERROR etc correctly. What we can potentially improve on the routing side is to read actual ZK metadata to determine the segment group, and after that it should remain the same. > > Essentially, the routing side change: > > * Is not a must have if we keep IS consistent (all segments of the same partition are assigned to the same set of servers) > * If IS is inconsistent, this won't be able to fix the query issue, but can return exception instead of potential wrong result > > Instead, the assignment side change is a must have, so I'd suggest not do routing side change as of now Yes, upon having discussion with Kishore offline I also think assignment side change is a must now and not this. I would focus on the assignment one first. I think only the logic in `SegmentAssignmentUtils` need to be changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
