snleee commented on code in PR #11490:
URL: https://github.com/apache/pinot/pull/11490#discussion_r1313702141
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileWriter.java:
##########
@@ -66,7 +65,10 @@ public void write(GenericRow genericRow)
@Override
public void close()
throws IOException {
- _offsetStream.close();
- _dataStream.close();
+ try {
Review Comment:
@Jackie-Jiang @swaminathanmanish what's the preferred way to handle this?
The current Manish's code is more elegant way of doing sth like the following?
When I looked up online, I get some answers like the following:
```
public void close() {
try {
_offsetStream.close()
} catch (IOException) {
// logging error
}
try {
_datastream.close()
} catch (IOException e) {
// log error
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
