swaminathanmanish commented on code in PR #11490:
URL: https://github.com/apache/pinot/pull/11490#discussion_r1316152953
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileWriter.java:
##########
@@ -66,7 +65,10 @@ public void write(GenericRow genericRow)
@Override
public void close()
throws IOException {
- _offsetStream.close();
- _dataStream.close();
+ try {
Review Comment:
Yes, we need the exception, but at the same time close resources. I prefer
the current way, unless you strongly feel otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
