jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1317637792
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -212,6 +225,59 @@ protected void doShutdown() {
if (_leaseExtender != null) {
_leaseExtender.shutDown();
}
+ // Make sure we do metric cleanup when we shut down the table.
+ _ingestionDelayTracker.shutdown();
Review Comment:
@jadami10 Once consumption stops, we do tick the measures reported by the
metric until the consuming thread is shutdown and yes there may be a ramping
delay depending on how long it takes to shutdown things. We can likely improve
that by marking shutdown in progress and stopping the ramp in time, this may
help with heavily loaded servers to stop ramping during long-lasting shutdown.
If that makes sense please file an issue and we can try to reach consensus to
adding that feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
