eaugene commented on code in PR #11561:
URL: https://github.com/apache/pinot/pull/11561#discussion_r1322479682
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -63,8 +65,8 @@ public Exception getException() {
@Override
public Boolean call()
throws Exception {
- String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-"
- + _streamConfig.getTableNameWithType() + "-" + _topicName;
+ String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() +
"-" + _topicName + "-try" + Integer
+ .toString(++_callRetries);
Review Comment:
> If your goal is to handle intermittent issues like DNS failures then the
MBean won't be registered either ways because the AppInfoParser call is the
last call
Thanks for pointing out. I am reverting the change of adding retry ids
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
