ankitsultana commented on code in PR #11561:
URL: https://github.com/apache/pinot/pull/11561#discussion_r1323172892
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaConsumerFactory.java:
##########
@@ -25,18 +25,22 @@
public class KafkaConsumerFactory extends StreamConsumerFactory {
+ private static final String _PARTITION_LEVEL_CONSUMER =
"_partition_level_consumer";
Review Comment:
should these begin with dots to improve readability?
```
private static final String _PARTITION_LEVEL_CONSUMER =
".partition_level_consumer";
...
```
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1437,6 +1438,7 @@ public LLRealtimeSegmentDataManager(SegmentZKMetadata
segmentZKMetadata, TableCo
new SegmentErrorInfo(now(), "Failed to initialize the
StreamMessageDecoder", e));
throw e;
}
+ _clientId = streamTopic + "-" + _partitionGroupId;
Review Comment:
Client Id was `_clientId = _tableNameWithType + "-" + streamTopic + "-" +
_partitionGroupId;` before this PR.
We should still use that right? We didn't want to change the clientId afaik
and only wanted the metricKeyName to be set separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
