shenyu0127 commented on code in PR #11653:
URL: https://github.com/apache/pinot/pull/11653#discussion_r1339518401
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunctionTest.java:
##########
@@ -237,6 +239,26 @@ private void testCaseQueryWithStringResults(String
predicate, String[] expectedV
testTransformFunction(transformFunction, expectedValues);
}
+ @Test
+ public void testCaseTransformationWithNullColumn() {
Review Comment:
This test exercises the `CaseTransformFunction`. We want to fix the
`ScalarTransformFunctionWrapper` and add a test to exercise the
`ScalarTransformFunctionWrapper` that wraps `ObjectFunctions::caseWhen`.
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunctionTest.java:
##########
@@ -580,9 +580,14 @@ protected void testTransformFunction(TransformFunction
transformFunction, String
protected void testTransformFunctionWithNull(TransformFunction
transformFunction, String[] expectedValues,
RoaringBitmap expectedNulls) {
+ testTransformFunctionWithNull(transformFunction, expectedValues,
expectedNulls, false);
+ }
+
+ protected void testTransformFunctionWithNull(TransformFunction
transformFunction, String[] expectedValues,
Review Comment:
We don't need to define this function because we can use the
`testTransformFunction`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
