shenyu0127 commented on code in PR #11653:
URL: https://github.com/apache/pinot/pull/11653#discussion_r1342052930
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapper.java:
##########
@@ -444,4 +446,10 @@ private void getNonLiteralValues(ValueBlock valueBlock) {
}
}
}
+
+ @Nullable
Review Comment:
We don't need to define this function because we can inherit the function
from the subclass.
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunctionTest.java:
##########
@@ -237,6 +239,26 @@ private void testCaseQueryWithStringResults(String
predicate, String[] expectedV
testTransformFunction(transformFunction, expectedValues);
}
+ @Test
+ public void testCaseTransformationWithNullColumn() {
Review Comment:
If your PR is "Added calls for BaseTransformation init function for NULL
support", suggest to revert this irrelevant test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
