klsince commented on code in PR #11711:
URL: https://github.com/apache/pinot/pull/11711#discussion_r1342932676
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -313,6 +325,36 @@ private void handlePostCreation()
buildStarTreeV2IfNecessary(segmentOutputDir);
}
+ Set<IndexType> postSegCreationIndexes =
IndexService.getInstance().getAllIndexes().stream()
Review Comment:
for a bit more readability, wrap those new changes to a method like
`addIndexIfNecessary`
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/IndexType.java:
##########
@@ -38,6 +38,11 @@
* @param <IC> the {@link IndexCreator} subclass that should be used to create
indexes of this type.
*/
public interface IndexType<C extends IndexConfig, IR extends IndexReader, IC
extends IndexCreator> {
+ enum IndexBuildLifecycle {
+ DURING_SEGMENT_CREATION,
+ POST_SEGMENT_CREATION,
+ CUSTOM
Review Comment:
nit: just call it`BuildTime` as this enum is defined as part of IndexType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
