zhtaoxiang commented on code in PR #11711:
URL: https://github.com/apache/pinot/pull/11711#discussion_r1343059132
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -313,6 +325,36 @@ private void handlePostCreation()
buildStarTreeV2IfNecessary(segmentOutputDir);
}
+ Set<IndexType> postSegCreationIndexes =
IndexService.getInstance().getAllIndexes().stream()
+ .filter(indexType -> indexType.getIndexBuildLifecycle() ==
IndexType.IndexBuildLifecycle.POST_SEGMENT_CREATION)
+ .collect(Collectors.toSet());
+
+ if (postSegCreationIndexes.size() > 0) {
+ // Build other indexes
+ Map<String, Object> props = new HashMap<>();
+ props.put(IndexLoadingConfig.READ_MODE_KEY, ReadMode.mmap);
Review Comment:
Thanks for the explanation! I think it's a good starting point if
PinotRecordReader always uses mmap. We can revisit this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
