yupeng9 commented on code in PR #11731:
URL: https://github.com/apache/pinot/pull/11731#discussion_r1346162654
##########
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/ScalarFunctions.java:
##########
@@ -56,9 +57,9 @@ public static byte[] stPoint(double x, double y) {
* @return the created point
*/
@ScalarFunction(names = {"stPoint", "ST_point"})
- public static byte[] stPoint(double x, double y, boolean isGeography) {
+ public static byte[] stPoint(double x, double y, Object isGeography) {
Point point = GeometryUtils.GEOMETRY_FACTORY.createPoint(new Coordinate(x,
y));
- if (isGeography) {
+ if (BooleanUtils.toBoolean(isGeography)) {
Review Comment:
I see. for non-boolean value, will it handle exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
