xiangfu0 commented on code in PR #11731:
URL: https://github.com/apache/pinot/pull/11731#discussion_r1344858820
##########
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/StPointFunction.java:
##########
@@ -79,8 +83,16 @@ public byte[][] transformToBytesValuesSV(ValueBlock
valueBlock) {
double[] firstValues =
_firstArgument.transformToDoubleValuesSV(valueBlock);
double[] secondValues =
_secondArgument.transformToDoubleValuesSV(valueBlock);
for (int i = 0; i < valueBlock.getNumDocs(); i++) {
- _results[i] = ScalarFunctions.stPoint(firstValues[i], secondValues[i],
_isGeography);
+ _results[i] = stPoint(firstValues[i], secondValues[i], _isGeography);
}
return _results;
}
+
+ static byte[] stPoint(double x, double y, boolean isGeography) {
Review Comment:
Copy here to avoid the unnecessary type conversion from scalar function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
