Jackie-Jiang commented on code in PR #11732:
URL: https://github.com/apache/pinot/pull/11732#discussion_r1346288139
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/LiteralOperand.java:
##########
@@ -28,7 +29,22 @@ public class LiteralOperand implements TransformOperand {
public LiteralOperand(RexExpression.Literal rexExpression) {
_resultType = rexExpression.getDataType();
- _value = rexExpression.getValue();
+ _value = convert(rexExpression.getValue());
Review Comment:
We want to convert the value to the internal type. I think `TIMESTAMP` might
not be handled correctly right now, where the raw value is not really the
external value format `Timestamp`, so we may add a special case for that and
add a TODO to fix that in the future
```suggestion
_value = _resultType.toInternal(rexExpression.getValue());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
