walterddr commented on code in PR #11732:
URL: https://github.com/apache/pinot/pull/11732#discussion_r1346291673
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/LiteralOperand.java:
##########
@@ -28,7 +29,22 @@ public class LiteralOperand implements TransformOperand {
public LiteralOperand(RexExpression.Literal rexExpression) {
_resultType = rexExpression.getDataType();
- _value = rexExpression.getValue();
+ _value = convert(rexExpression.getValue());
Review Comment:
+1. this and the rest of the places, ProtoSer/De only provide an identical
mapping from ser/de perspective. for this particular situation, we need to
leverage the RexExpression.Literal structure, which not only encode the value
but also the type
we also need to make sure that proto ser/de only accepts particular type -->
if the data is `ByteArray`, `byte[]`, or `ByteString` which can all ser/de
into `ByteString` we should not allow that --> e.g. need to make sure the
Ser/De is symmetrics
particularly in this case we should not allow the object to be
GeogeorianCalendar --> it shouldl explicitly converted into long before setting
it into the Literal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
