cbalci commented on code in PR #11774:
URL: https://github.com/apache/pinot/pull/11774#discussion_r1357254877
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -515,23 +518,23 @@ public VarianceTuple deserialize(ByteBuffer byteBuffer) {
}
};
- public static final ObjectSerDe<PinotFourthMoment>
PINOT_FOURTH_MOMENT_OBJECT_SER_DE
- = new ObjectSerDe<PinotFourthMoment>() {
- @Override
- public byte[] serialize(PinotFourthMoment value) {
- return value.serialize();
- }
+ public static final ObjectSerDe<PinotFourthMoment>
PINOT_FOURTH_MOMENT_OBJECT_SER_DE =
+ new ObjectSerDe<PinotFourthMoment>() {
+ @Override
+ public byte[] serialize(PinotFourthMoment value) {
+ return value.serialize();
+ }
- @Override
- public PinotFourthMoment deserialize(byte[] bytes) {
- return PinotFourthMoment.fromBytes(bytes);
- }
+ @Override
+ public PinotFourthMoment deserialize(byte[] bytes) {
+ return PinotFourthMoment.fromBytes(bytes);
+ }
- @Override
- public PinotFourthMoment deserialize(ByteBuffer byteBuffer) {
- return PinotFourthMoment.fromBytes(byteBuffer);
- }
- };
+ @Override
+ public PinotFourthMoment deserialize(ByteBuffer byteBuffer) {
+ return PinotFourthMoment.fromBytes(byteBuffer);
+ }
+ };
Review Comment:
Not sure if there is an explicit guideline for this repo, but I think it
would be better to separate functional and formatting changes into different
PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
