davecromberge commented on PR #11774:
URL: https://github.com/apache/pinot/pull/11774#issuecomment-1761688844

   I have tested the following features on this PR:
   - ingestion transformation function using baseball stats
   - segment rollup aggregation with MergeRollupTask
   - StarTree aggregation
   - query aggregation
   
   Accumulating results on a server into a list before merging yielded marginal 
performance gains at the cost of code complexity and this approach was 
abandoned.  
   
   Some ideas for future improvement are:
   - extensible aggregation functions via plugin system
   - adding sub-packages to the existing aggregation functions and factoring 
out common parts.
   
   For the second point, a base class has been used in some instances and a 
similar approach could be used with the sketch implementations - with the 
exception of the Theta Sketch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to