dang-stripe commented on code in PR #11799:
URL: https://github.com/apache/pinot/pull/11799#discussion_r1364448365
##########
pinot-plugins/pinot-file-system/pinot-s3/pom.xml:
##########
@@ -39,6 +39,7 @@
<http.core.version>4.4.13</http.core.version>
<s3mock.version>2.12.2</s3mock.version>
<javax.version>3.1.0</javax.version>
+ <woodstox.version>5.3.0</woodstox.version>
Review Comment:
@abhioncbr @Jackie-Jiang i feel like it'd be better to keep the dependency
closer to the plugins that actually need it? for this case, this dep is
specifically used by the aws sdk.
```
[2023-10-10 04:21:35.000157] at
software.amazon.awssdk.services.s3.DefaultS3Client.listObjectsV2(DefaultS3Client.java:5614)
~[pinot-s3-0.13.0-2023-10-09-3ed8e67fe7-SNAPSHOT-shaded.jar:0.13.0-2023-10-09-3ed8e67fe7-SNAPSHOT-3ed8e67fe789f4f16c78c2d9fcad6a6bf27f0a79]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
