dang-stripe commented on code in PR #11799:
URL: https://github.com/apache/pinot/pull/11799#discussion_r1365944790
##########
pinot-plugins/pinot-file-system/pinot-s3/pom.xml:
##########
@@ -39,6 +39,7 @@
<http.core.version>4.4.13</http.core.version>
<s3mock.version>2.12.2</s3mock.version>
<javax.version>3.1.0</javax.version>
+ <woodstox.version>5.3.0</woodstox.version>
Review Comment:
@Jackie-Jiang @abhioncbr i added a `dependencyManagement` section to make
the pinot-file-system plugins use the same version of woodstox, but ran into a
conflict in CI:
```
Error: Dependency convergence error for
com.fasterxml.woodstox:woodstox-core:jar:5.3.0 paths to dependency are:
Error: +-org.apache.pinot:pinot-tools:jar:1.1.0-SNAPSHOT
Error: +-org.apache.hadoop:hadoop-common:jar:3.2.4:compile
Error: +-com.fasterxml.woodstox:woodstox-core:jar:5.3.0:compile
Error: and
Error: +-org.apache.pinot:pinot-tools:jar:1.1.0-SNAPSHOT
Error: +-org.apache.pinot:pinot-s3:jar:1.1.0-SNAPSHOT:runtime
Error: +-com.fasterxml.woodstox:woodstox-core:jar:6.4.0:runtime
```
i think 5.3.0 is the version required by [hadoop-common
3.2.4](https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-common/3.2.4)
at the root level of the pinot project. it seems like the option here are to
move the `dependencyManagement` version clause to the root level and set as
5.3.0 which downgrades the version used by `pinot-adls`. does that seem
reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
