snleee commented on code in PR #11955:
URL: https://github.com/apache/pinot/pull/11955#discussion_r1383746812
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/task/AdhocTaskConfig.java:
##########
@@ -57,6 +57,7 @@ public AdhocTaskConfig(@JsonProperty(value = "taskType",
required = true) String
@JsonProperty("taskConfigs") @Nullable Map<String, String> taskConfigs) {
Preconditions.checkArgument(taskType != null, "'taskType' must be
configured");
Preconditions.checkArgument(tableName != null, "'tableName' must be
configured");
+ Preconditions.checkArgument(taskName == null || !taskName.contains("/"),
"'taskName' must not contain '/'");
Review Comment:
Can we double check if the task generator explicitly creates the task name
or the helix implicitly generates the task name?
If it's the first case, we should add the validation on the task name
generated by the task generator as well. If the name gets created by the helix
internally, we wouldn't need to worry about this.
@swaminathanmanish We should consider to remove the task name input from the
customer. Ideally, we should internally create the task id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
