swaminathanmanish commented on code in PR #11955:
URL: https://github.com/apache/pinot/pull/11955#discussion_r1383822916
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/task/AdhocTaskConfig.java:
##########
@@ -57,6 +57,7 @@ public AdhocTaskConfig(@JsonProperty(value = "taskType",
required = true) String
@JsonProperty("taskConfigs") @Nullable Map<String, String> taskConfigs) {
Preconditions.checkArgument(taskType != null, "'taskType' must be
configured");
Preconditions.checkArgument(tableName != null, "'tableName' must be
configured");
+ Preconditions.checkArgument(taskName == null || !taskName.contains("/"),
"'taskName' must not contain '/'");
Review Comment:
@aishikbh - Could you add this to your message
**taskName' must not contain path separator '/'**
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/task/AdhocTaskConfig.java:
##########
@@ -57,6 +57,7 @@ public AdhocTaskConfig(@JsonProperty(value = "taskType",
required = true) String
@JsonProperty("taskConfigs") @Nullable Map<String, String> taskConfigs) {
Preconditions.checkArgument(taskType != null, "'taskType' must be
configured");
Preconditions.checkArgument(tableName != null, "'tableName' must be
configured");
+ Preconditions.checkArgument(taskName == null || !taskName.contains("/"),
"'taskName' must not contain '/'");
Review Comment:
Its created outside Helix by PinotTaskManager. We can remove the
documentation for custom askName and deprecate it?
if (taskName == null) {
taskName = tableName + "_" + UUID.randomUUID();
LOGGER.info("Task name is missing, auto-generate one: {}", taskName);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
