gortiz commented on code in PR #12270:
URL: https://github.com/apache/pinot/pull/12270#discussion_r1453156491
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TestZkBasedTableRebalanceObserver.java:
##########
@@ -41,10 +45,13 @@ void testZkObserverTracking() {
PinotHelixResourceManager pinotHelixResourceManager =
mock(PinotHelixResourceManager.class);
// Mocking this. We will verify using numZkUpdate stat
when(pinotHelixResourceManager.addControllerJobToZK(any(), any(),
any())).thenReturn(true);
+ ControllerMetrics controllerMetrics =
Mockito.mock(ControllerMetrics.class);
+ doNothing().when(controllerMetrics).setValueOfTableGauge("dummy",
ControllerGauge.TABLE_REBALANCE_IN_PROGRESS, 0);
+ doNothing().when(controllerMetrics).setValueOfTableGauge("dummy",
ControllerGauge.TABLE_REBALANCE_IN_PROGRESS, 1);
Review Comment:
Do we actually need this? Isn't do nothing the default mockito behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
