Jackie-Jiang commented on code in PR #12270:
URL: https://github.com/apache/pinot/pull/12270#discussion_r1456549526
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java:
##########
@@ -48,23 +50,29 @@ public class ZkBasedTableRebalanceObserver implements
TableRebalanceObserver {
private boolean _isStopped = false;
private RebalanceResult.Status _stopStatus;
+ private ControllerMetrics _controllerMetrics;
+
public ZkBasedTableRebalanceObserver(String tableNameWithType, String
rebalanceJobId,
- TableRebalanceContext tableRebalanceContext, PinotHelixResourceManager
pinotHelixResourceManager) {
+ TableRebalanceContext tableRebalanceContext, PinotHelixResourceManager
pinotHelixResourceManager,
+ ControllerMetrics controllerMetrics) {
Review Comment:
No need to pass it. Use `ControllerMetrics.get()` to get the singleton
instance
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -231,6 +231,10 @@ public String forTableForceCommit(String tableName) {
return StringUtil.join("/", _baseUrl, "tables", tableName, "forceCommit");
}
+ public String forTableToBrokerMappings() {
Review Comment:
Is this related?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java:
##########
@@ -48,23 +50,29 @@ public class ZkBasedTableRebalanceObserver implements
TableRebalanceObserver {
private boolean _isStopped = false;
private RebalanceResult.Status _stopStatus;
+ private ControllerMetrics _controllerMetrics;
Review Comment:
This can be `final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
