vvivekiyer commented on code in PR #12347:
URL: https://github.com/apache/pinot/pull/12347#discussion_r1473959548
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java:
##########
@@ -1024,7 +1024,8 @@ public Comparable
extractFinalResult(List<ThetaSketchAccumulator> accumulators)
int numAccumulators = accumulators.size();
List<Sketch> mergedSketches = new ArrayList<>(numAccumulators);
- for (ThetaSketchAccumulator accumulator : accumulators) {
+ for (Object accumulatorObject : accumulators) {
Review Comment:
Please make this change in
`DistinctCountRawThetaSketchAggregationFunction.extractFinalResult()` to ensure
backward compatibility.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java:
##########
@@ -1024,7 +1024,8 @@ public Comparable
extractFinalResult(List<ThetaSketchAccumulator> accumulators)
int numAccumulators = accumulators.size();
List<Sketch> mergedSketches = new ArrayList<>(numAccumulators);
- for (ThetaSketchAccumulator accumulator : accumulators) {
+ for (Object accumulatorObject : accumulators) {
+ ThetaSketchAccumulator accumulator =
convertSketchAccumulator(accumulatorObject);
Review Comment:
(Not related to your code) Consider reusing convertSketchAccumulator()
function in L980 to avoid code duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
