jackjlli commented on code in PR #12347:
URL: https://github.com/apache/pinot/pull/12347#discussion_r1477202071
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountRawThetaSketchAggregationFunction.java:
##########
@@ -53,7 +53,8 @@ public String extractFinalResult(List<ThetaSketchAccumulator>
accumulators) {
int numAccumulators = accumulators.size();
List<Sketch> mergedSketches = new ArrayList<>(numAccumulators);
- for (ThetaSketchAccumulator accumulator : accumulators) {
+ for (Object object : accumulators) {
Review Comment:
Good question! It could be possible that there is only 1 old server
returning a non-empty intermediate result, which skipped the merge step in
broker.
I've tested this code by setting up a local cluster and running 2 servers
with old version and 1 broker with new version, and I don't see exception any
more. So we should be good with this hotfix PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
