tibrewalpratik17 commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1536170709
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapTableUpsertMetadataManager.java:
##########
@@ -55,6 +58,14 @@ public Map<Integer, Long> getPartitionToPrimaryKeyCount() {
return partitionToPrimaryKeyCount;
}
+ @Override
+ public Map<IndexSegment, SegmentContext>
getSegmentContexts(List<IndexSegment> selectedSegments) {
+ Map<IndexSegment, SegmentContext> segmentContexts = new HashMap<>();
+ _partitionMetadataManagerMap.forEach(
+ (k, v) -> v.getUpsertView(selectedSegments, segmentContexts));
+ return segmentContexts;
+ }
Review Comment:
pretty neat!
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -256,8 +257,9 @@ private InstanceResponseBlock
executeInternal(ServerQueryRequest queryRequest, E
InstanceResponseBlock instanceResponse = null;
try {
- instanceResponse = executeInternal(indexSegments, queryContext,
timerContext, executorService, streamer,
- queryRequest.isEnableStreaming());
+ instanceResponse =
+ executeInternal(tableDataManager, indexSegments, queryContext,
timerContext, executorService, streamer,
+ queryRequest.isEnableStreaming());
Review Comment:
nit: can we pass List<SegmentContext> itself instead of tableDataManager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
