klsince commented on code in PR #12694:
URL: https://github.com/apache/pinot/pull/12694#discussion_r1536258715


##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -256,8 +257,9 @@ private InstanceResponseBlock 
executeInternal(ServerQueryRequest queryRequest, E
 
     InstanceResponseBlock instanceResponse = null;
     try {
-      instanceResponse = executeInternal(indexSegments, queryContext, 
timerContext, executorService, streamer,
-          queryRequest.isEnableStreaming());
+      instanceResponse =
+          executeInternal(tableDataManager, indexSegments, queryContext, 
timerContext, executorService, streamer,
+              queryRequest.isEnableStreaming());

Review Comment:
   inside executeInternal() the list of indexSegments is pruned firstly, so 
passing tableDataManager into executeInternal() to call the 
getSegmentContexts() method after pruning just for the remaining indexSegments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to