shounakmk219 commented on code in PR #12739:
URL: https://github.com/apache/pinot/pull/12739#discussion_r1543366902
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -241,7 +242,7 @@ public void cleanupSegmentCountGauge(final String resource)
{
@VisibleForTesting
public static String makeGaugeName(final String resource, final String
gaugeName) {
- return "pinot.controller." + resource + "." + gaugeName;
+ return "pinot.controller." + StringUtils.replaceOnce(resource, ".", "#") +
"." + gaugeName;
Review Comment:
1. yes that's the assumption and I have cross checked all the usages and all
the caller functions are passing table name as resource.
2. meter and timer use the `AbstractMetrics.getTableName` method which also
has the handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
