zhtaoxiang commented on code in PR #12739:
URL: https://github.com/apache/pinot/pull/12739#discussion_r1547100308
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -133,124 +134,126 @@ public ValidationMetrics(PinotMetricsRegistry
metricsRegistry) {
/**
* Updates the missing segment count gauge.
*
- * @param resource The resource for which the gauge is updated
+ * @param tableNameWithType The table name with type for which the gauge is
updated
Review Comment:
since we are changing the comment and parameter names now: can we change to
`tableNameWithTypeAndDb?
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -133,124 +134,126 @@ public ValidationMetrics(PinotMetricsRegistry
metricsRegistry) {
/**
* Updates the missing segment count gauge.
*
- * @param resource The resource for which the gauge is updated
+ * @param tableNameWithType The table name with type for which the gauge is
updated
Review Comment:
since we are changing the comment and parameter names now: can we change to
`tableNameWithTypeAndDb`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
