wirybeaver commented on code in PR #12744:
URL: https://github.com/apache/pinot/pull/12744#discussion_r1552866049
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -218,6 +224,19 @@ public void init(SegmentGeneratorConfig config,
SegmentCreationDataSource dataSo
LOGGER.debug("tempIndexDir:{}", _tempIndexDir);
}
+ // input int[] can be used to map sortedDocIds[immutableId] = mutableId
(based on RecordReader iteration order)
+ // output int[] should be used to map output[mutableId] = immutableId
+ private int[] convertSortedDocIds(@Nullable int[] sortedDocIds) {
Review Comment:
IIUC, if the table have sort index, then the docIds need to be sorted
accordingly when generate immutable segment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
